Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: benchmarks #2059

Merged
merged 22 commits into from
Feb 28, 2025
Merged

fix: benchmarks #2059

merged 22 commits into from
Feb 28, 2025
+41 −53

Conversation

Shvandre
Copy link
Contributor

@Shvandre Shvandre commented Feb 27, 2025 •
edited
Loading

Issue

Closes #1930

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Shvandre Shvandre requested a review from a team as a code owner February 27, 2025 12:20
@Shvandre Shvandre requested a review from i582 February 27, 2025 12:37
@Kaladin13 Kaladin13 mentioned this pull request Feb 27, 2025
Merged
4 tasks
@anton-trunov anton-trunov added this to the v1.6.0 milestone Feb 27, 2025
@anton-trunov anton-trunov self-assigned this Feb 27, 2025
@Kaladin13 Kaladin13 self-requested a review February 27, 2025 14:27
Kaladin13
Kaladin13 previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Kaladin13 Kaladin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and good to go

@Shvandre
Copy link
Contributor Author

image Unfortunately it increased gas usage because I've added some checks that were not necessary but exist in funC reference

@novusnota novusnota changed the title fix: bencmarks updates fix: benchmarks Feb 27, 2025
@Shvandre
Merge branch 'main' into B4ckSl4sh/jettonUpdates
02e25ed 
# Conflicts:
#	src/test/benchmarks/escrow/results.json
#	src/test/benchmarks/jetton/results.json
i582
i582 previously approved these changes Feb 28, 2025
View reviewed changes
@Shvandre
Copy link
Contributor Author

image

@Shvandre
fix
63ffefd
@Shvandre
Merge branch 'main' into B4ckSl4sh/jettonUpdates
ba8b68e 
# Conflicts:
#	src/test/benchmarks/contracts/jetton_minter_discoverable.tact
@Shvandre
fix
d7bd229
@anton-trunov anton-trunov merged commit 2ac2459 into main Feb 28, 2025
22 of 24 checks passed
@anton-trunov anton-trunov deleted the B4ckSl4sh/jettonUpdates branch February 28, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i582 i582 i582 left review comments

@Kaladin13 Kaladin13 Kaladin13 left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

src/test/benchmarks/contracts/jetton_wallet.tact should correspond to jetton-wallet.fc
4 participants
@Shvandre @i582 @Kaladin13 @anton-trunov