-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): change GuestOutput and the zk committed value for onchain verification #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& zk guest return pi hash directly
CeciliaZ030
temporarily deployed
to
test-environment
June 5, 2024 21:38
— with
GitHub Actions
Inactive
CeciliaZ030
temporarily deployed
to
test-environment
June 7, 2024 21:05
— with
GitHub Actions
Inactive
Brechtpd
approved these changes
Jun 8, 2024
CeciliaZ030
had a problem deploying
to
test-environment
June 9, 2024 00:34
— with
GitHub Actions
Failure
CeciliaZ030
changed the title
feat(prover): change GuestOutput and the zk committed value for onchain verification
feat(prover): change GuestOutput and the zk committed value for onchain verification
Jun 9, 2024
CeciliaZ030
had a problem deploying
to
test-environment
June 9, 2024 00:43
— with
GitHub Actions
Failure
CeciliaZ030
temporarily deployed
to
test-environment
June 9, 2024 00:52
— with
GitHub Actions
Inactive
dionysuzx
temporarily deployed
to
test-environment
June 9, 2024 00:59
— with
GitHub Actions
Inactive
…aikoxyz/raiko into guest-returns-ProtocalInstance
CeciliaZ030
temporarily deployed
to
test-environment
June 9, 2024 01:01
— with
GitHub Actions
Inactive
CeciliaZ030
temporarily deployed
to
test-environment
June 9, 2024 01:07
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zk provers should return the
ProtocolInput
hash to match the onchain verifier, when it fails to generatepi_hash
the proof should just fail and ZkVM should exit. In that case, theGuestOutput::Failure
will never be used and currently it's not used reasonably so we should just remove the case.change to:
For verifier support, see taikoxyz/taiko-mono#17215