Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support taiko protocol(rebase to the 3.5.0 revm) #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

johntaiko
Copy link
Collaborator

No description provided.

@johntaiko johntaiko self-assigned this Sep 7, 2023
Copy link

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool that taiko blocks already work with these small changes! Some checks still need to be added like verifying the anchor data but seems like that will be relatively easy. :) Oh yeah, like mentioned in my other comment on the zeth PR, a is_taiko_block in the long term seems useful again.

crates/revm/src/evm_impl.rs Outdated Show resolved Hide resolved
@johntaiko
Copy link
Collaborator Author

johntaiko commented Sep 10, 2023

Very cool that taiko blocks already work with these small changes! Some checks still need to be added like verifying the anchor data but seems like that will be relatively easy. :) Oh yeah, like mentioned in my other comment on the zeth PR, a is_taiko_block in the long term seems useful again.

yeah, for now the logic is same as taiko-geth. But i think we need more validation for our protocol
Another side, we need the metadata from l1 contract for anchor verification.
So, in zeth we need to depend the eth node extra

@johntaiko johntaiko closed this Oct 17, 2023
@johntaiko johntaiko reopened this Oct 17, 2023
@johntaiko johntaiko changed the title feat: support taiko protocol feat: support taiko protocol(rebase to the newest revm) Oct 17, 2023
@johntaiko johntaiko changed the title feat: support taiko protocol(rebase to the newest revm) feat: support taiko protocol(rebase to the 3.5.0 revm) Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants