fix(api): fix bug about miner.Pending call #357
Conversation
consensus/taiko/consensus.go
Outdated
| } | ||
| if !isAnchor { | ||
| return nil, ErrAnchorTxNotFound | ||
| if body.Transactions[0].IsAnchor() { |
There was a problem hiding this comment.
I remembered that the function IsAnchor() seems always to return false?
And I think using ValidateAnchorTx is enough.
There was a problem hiding this comment.
It's ok if the first tx is anchor tx.
There was a problem hiding this comment.
It can't happen that the first tx in the block to be finalised is not an anchor tx, can it?
There was a problem hiding this comment.
A new modification in this commit.
mask-pp
changed the title
consensus/taiko/consensus.go
Outdated
| } | ||
| if !isAnchor { | ||
| return nil, ErrAnchorTxNotFound | ||
| if body.Transactions[0].IsAnchor() { |
There was a problem hiding this comment.
The first tx in a L2 block must be an anchor tx, so no need to check this?
There was a problem hiding this comment.
A new modification in this commit.
Co-authored-by: Roger <[email protected]>
Co-authored-by: Roger <[email protected]>
Co-authored-by: Roger <[email protected]>
Co-authored-by: Roger <[email protected]>
Co-authored-by: Roger <[email protected]>
|
Emmm is there any case we will use |
|
Closed due to |
Suppose the calling link contains miner/miner.go:Pending() api and
txpool.Pendingis not empty, then return error(ErrAnchorTxNotFound).