-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple onRequest handlers #1863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 83.77% 82.74% -1.04%
==========================================
Files 198 183 -15
Lines 19379 18287 -1092
==========================================
- Hits 16235 15131 -1104
- Misses 3144 3156 +12 ☔ View full report in Codecov by Sentry. |
f7ab336
to
f9669b7
Compare
Action required: PR inactive for 2 days. |
@webbdays Can you please resolve the conflicts. |
Whenever you are ready, just mark it as ready to review. |
ok. |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
@webbdays I have made a few changes in the implementation. IF you could look at why the tests are failing, that would be great. I think overall it's ready to merge. Thanks once again! |
Ok. I will check that. |
Action required: PR inactive for 2 days. |
Co-authored-by: Tushar Mathur <[email protected]> Co-authored-by: amit <[email protected]>
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
/approve |
@tusharmath: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
Something is off on Algora so canceling your claim and giving you a tip instead. /tip 250 |
🎉🎈 @webbdays has been awarded $250! 🎈🎊 |
Summary:
multiple onRequest handlers
Issue Reference(s):
Fixes #1271
/claim #1271
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>