fix(grpc): type and field names for config from protobuf generation #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
+ Coverage 82.02% 82.06% +0.04%
==========================================
Files 173 173
Lines 17531 17608 +77
==========================================
+ Hits 14379 14450 +71
- Misses 3152 3158 +6 ☔ View full report in Codecov by Sentry. |
tusharmath
reviewed
May 9, 2024
tusharmath
reviewed
May 9, 2024
tusharmath
reviewed
May 9, 2024
tusharmath
reviewed
May 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tushar Mathur <[email protected]>
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
github-actions
bot
removed
the
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
Co-authored-by: Tushar Mathur <[email protected]>
tusharmath
approved these changes
May 16, 2024
TheWizardTower
pushed a commit
to TheWizardTower/tailcall
that referenced
this pull request
May 16, 2024
…ailcallhq#1895) Co-authored-by: Tushar Mathur <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #1754, fixes #1899, fixes #1897, fixes #1898
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>