Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce cloning for dedupe #3025

Merged
merged 108 commits into from
Oct 24, 2024
Merged

fix: reduce cloning for dedupe #3025

merged 108 commits into from
Oct 24, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Oct 17, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Base automatically changed from pref/small-improvements to main October 21, 2024 05:14
@github-actions github-actions bot added the type: performance Improved performance. label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 82.57261% with 84 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (d520ee4) to head (1b563f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/graphql_error.rs 69.65% 44 Missing ⚠️
src/core/async_graphql_hyper.rs 91.12% 11 Missing ⚠️
src/core/http/request_handler.rs 62.06% 11 Missing ⚠️
src/core/jit/response.rs 88.15% 9 Missing ⚠️
src/core/jit/model.rs 55.55% 4 Missing ⚠️
src/core/jit/exec_const.rs 80.00% 2 Missing ⚠️
src/core/jit/transform/check_protected.rs 92.00% 2 Missing ⚠️
src/core/jit/error.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
- Coverage   87.35%   87.19%   -0.16%     
==========================================
  Files         275      277       +2     
  Lines       27171    27473     +302     
==========================================
+ Hits        23735    23956     +221     
- Misses       3436     3517      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@tusharmath tusharmath changed the title perf: reduce cloning for dedupe fix: reduce cloning for dedupe Oct 24, 2024
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Oct 24, 2024
@tusharmath tusharmath merged commit 9fe3dc1 into main Oct 24, 2024
33 of 35 checks passed
@tusharmath tusharmath deleted the perf/reduce-cloning-for-dedupe branch October 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure. type: performance Improved performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants