fix(auth): use the full format for the JWT payload in IAPToken #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanamari94
requested review from
cphoward and
santiagofdialpad
and removed request for
a team
juanamari94
force-pushed
the
feat/iap-gce-metadata
branch
from
373225a to
b3804a7
Compare
shaundialpad
approved these changes
Jun 13, 2024
auth/pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "gcloud-aio-auth" | |||
| version = "5.3.1" | |||
| version = "5.3.2a0" | |||
There was a problem hiding this comment.
Friendly non alpha reminder
There was a problem hiding this comment.
➕ HOSTILE PLUS ONE REPLY COMMENT
eddiedialpad
approved these changes
Jun 14, 2024
Some of the GCP products when retrieving the JWT token from the GCE Metadata Server come with the `email` claim, but some have recently started not returning that claim as part of the JWT payload. Adding the `format=full` query parameter to the GCE Metadata Server API seems to return the `email` claim for these cases, along with other GCE Metadata which for the time being we do not need and thus, we discard. [See these docs for more information.](https://cloud.google.com/compute/docs/instances/verifying-instance-identity#request_signature)
juanamari94
force-pushed
the
feat/iap-gce-metadata
branch
from
b3804a7 to
864033e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the GCP products when retrieving the JWT token from the GCE
Metadata Server come with the
emailclaim, but some have recentlystarted not returning that claim as part of the JWT payload. Adding the
format=fullquery parameter to the GCE Metdata Server API seems toreturn the
emailclaim for these cases, along with other GCE Metadatawhich for the time being we do not need and thus, we discard.
See these docs for more
information.