Remove no module named work error (#1956)

* Do not always color skeletons table black * Remove offending (possibly unneeded) line that causes the no module named work error to print in terminal * Remove offending (possibly unneeded) line that causes the no module named work error to print in terminal * Remove accidentally added changes * Add (failing) test to ensure menu-item updates with state change * Reconnect callback for menu-item (using lambda) * Add (failing) test to ensure menu-item updates with state change Do not assume inital state * Reconnect callback for menu-item (using lambda) --------- Co-authored-by: roomrys <[email protected]>
talmolab · Sep 11, 2024 · e4bb444 · e4bb444
1 parent c090df3
commit e4bb444
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/sleap/gui/app.py b/sleap/gui/app.py
@@ -377,7 +377,9 @@ def add_menu_item(menu, key: str, name: str, action: Callable):
         def connect_check(key):
             self._menu_actions[key].setCheckable(True)
             self._menu_actions[key].setChecked(self.state[key])
-            self.state.connect(key, self._menu_actions[key].setChecked)
+            self.state.connect(
+                key, lambda checked: self._menu_actions[key].setChecked(checked)
+            )
 
         # add checkable menu item connected to state variable
         def add_menu_check_item(menu, key: str, name: str):

diff --git a/tests/gui/test_app.py b/tests/gui/test_app.py
@@ -414,6 +414,12 @@ def toggle_and_verify_visibility(expected_visibility: bool = True):
         window.showNormal()
     vp = window.player
 
+    # Change state and ensure menu-item check updates
+    color_predicted = window.state["color predicted"]
+    assert window._menu_actions["color predicted"].isChecked() == color_predicted
+    window.state["color predicted"] = not color_predicted
+    assert window._menu_actions["color predicted"].isChecked() == (not color_predicted)
+
     # Enable distinct colors
     window.state["color predicted"] = True