-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain attrs (mac) and opencv (linux) in 1.3.4 #1927
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
+ Coverage 65.97% 73.12% +7.14%
==========================================
Files 127 134 +7
Lines 21378 23963 +2585
==========================================
+ Hits 14105 17522 +3417
+ Misses 7273 6441 -832 ☔ View full report in Codecov by Sentry. |
We are not merging this PR into main and will be deleting this branch (after 1.4.2 release). The source code will remain available as an asset in the 1.3.4 release notes and also through the v1.3.4 tag. |
Already built and tested
Description
This PR is a hotfix to add further constraints to
attrs
(<22.2.0
) andopencv
(<=4.8.1 # [linux]
).Items
Manual Installation Tests
Linux
GUI Training
Terminal: Training
Terminal: Opening GUI
Nothing.
sleap-label
mm create sleap
Windows
GUI Training
Terminal: Training
Terminal: Opening Training GUI
sleap-label
![image](https://github.com/user-attachments/assets/f31a7665-250c-48fd-bd4c-7ac30c2b2b15)mamba create sleap
Mac
GUI Training
Terminal: Opening Training GUI
Terminal: Training
sleap-label
mm create sleap
attrs
andopencv
constraints added here as they will be more officially handled in develop before the next release.Perhaps we release from this branch (not main) and delete this branch instead of merging into main? The source code would still be able to be accessed through the tags and the zipped source code in the release.
Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️