Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor skeleton.to_json to serialize skeleton object without jsonpickle #1934

Closed
wants to merge 20 commits into from
Closed

Refactor skeleton.to_json to serialize skeleton object without jsonpickle #1934

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cb62a2d
comment in `to_json` to start
eberrigan Sep 3, 2024
4c03ca2
fix confusing typo
eberrigan Sep 3, 2024
f352d03
add logic from sleap-io `serialize_skeletons` to `Skeleton.to_json` a…
eberrigan Sep 4, 2024
94dccb0
clean docstring
eberrigan Sep 4, 2024
4febed0
replace relabel nodes logic using networkx with custom indexing logic
eberrigan Sep 4, 2024
c3448f4
make dictionary directly instead of a list with a dictionary and save…
eberrigan Sep 4, 2024
3a7e65a
no attributes edge.source and edge.destination in SLEAP
eberrigan Sep 5, 2024
08b43ed
Merge branch 'develop' into elizabeth/refactor-skeletons-serialization
eberrigan Sep 10, 2024
5decb55
add to_json functions using sleap-io logic
eberrigan Sep 10, 2024
622853c
save changes to serialize skeletons
eberrigan Sep 11, 2024
884da47
match everything except indexing to legacy sleap
eberrigan Sep 11, 2024
06f18ab
Merge branch 'develop' into elizabeth/refactor-skeletons-serialization
eberrigan Sep 12, 2024
6e37ca9
move nodes list before links
eberrigan Sep 13, 2024
01d0255
format
eberrigan Sep 13, 2024
71b0307
symmetry is a tuple of nodes
eberrigan Sep 13, 2024
69db671
source and target should be tuples in edge dict
eberrigan Sep 13, 2024
0e2f9b5
check-in notebook for testing
eberrigan Sep 17, 2024
4ff6fdb
refer to source and target nodes using "py/id"
eberrigan Sep 17, 2024
f0451c5
use source and target nodes to index
eberrigan Sep 17, 2024
b4f10af
use tuple format for Node
eberrigan Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sleap/skeleton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,7 @@ def to_json(self, node_to_idx: Optional[Dict[Node, int]] = None) -> str:
Returns:
A string containing the JSON representation of the skeleton.
"""
# TODO: Replace jsonpickle with a custom encoder from sleap-io.
jsonpickle.set_encoder_options("simplejson", sort_keys=True, indent=4)
if node_to_idx is not None:
indexed_node_graph = nx.relabel_nodes(
Expand Down