-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing imageio-ffmpeg to meta.ymls #1943
Conversation
WalkthroughThe changes involve the addition of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .conda/meta.yaml (2 hunks)
- .conda_mac/meta.yaml (2 hunks)
Additional comments not posted (4)
.conda_mac/meta.yaml (2)
37-37
: Dependency addition approved.The addition of
imageio-ffmpeg
in thehost
section is correctly implemented and well-documented.
67-67
: Dependency addition approved.The addition of
imageio-ffmpeg
in therun
section is correctly implemented and well-documented..conda/meta.yaml (2)
36-36
: Dependency addition approved for the host section.The addition of
conda-forge::imageio-ffmpeg
is correctly placed in thehost
section and properly formatted. The accompanying comment provides clear context for its necessity, which is good for maintainability.
64-64
: Dependency addition approved for the run section.The addition of
conda-forge::imageio-ffmpeg
in therun
section is correctly formatted and appropriately placed. This ensures that the dependency is available at runtime, which is crucial for the functionality of theimageio
library.
Description
In #1935, thanks to the new workflow, we found that the
imageio-ffmpeg
dependency is missing from the meta.ymls used to build the conda packages (see this repo search of the develop branch). This fix was already added to #1841, but I will clean up that branch s.t. the fix is pulled in from develop (as the bug affects both branches).This PR add the
imageio-ffmpeg
dependency to the meta.ymls.Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
imageio-ffmpeg
dependency in both main and mac-specific environments.