-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle skeleton encoding internally #1970
Merged
roomrys
merged 40 commits into
develop
from
elizabeth/handle-skeleton-encoding-internally
Sep 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
034cffb
start class `SkeletonEncoder`
eberrigan dd4865d
start class `SkeletonEncoder`
eberrigan f66a12d
_encoded_objects need to be a dict to add to
eberrigan 7c48903
add notebook for testing
eberrigan 4a75924
format
eberrigan 57ec9d3
fix type in docstring
eberrigan 58b2398
finish classmethod for encoding Skeleton as a json string
eberrigan 8aedebd
test encoded Skeleton as json string by decoding it
eberrigan b9973c2
add test for decoded encoded skeleton
eberrigan 4d77a68
update jupyter notebook for easy testing
eberrigan 6c96a0e
constraining attrs in dev environment to make sure decode format is a…
eberrigan c78e9a9
encode links first then encode source then target then type
eberrigan 5935b6a
save first enconding statically as an input to _get_or_assign_id so t…
eberrigan cab40c2
save first encoding statically
eberrigan 2068fdd
first encoding is passed to _get_or_assign_id
eberrigan 61c7cc0
use first_encoding variable to determine if we should assign a py/id
eberrigan c4f5be9
add print statements for debugging
eberrigan 839d67c
update notebook for easy testing
eberrigan 5bcea83
black
eberrigan 167ef77
remove comment
eberrigan 28f0c61
adding attrs constraint to show this passes for certain attrs version…
eberrigan fd14ad0
add import
eberrigan 7fa9517
switch out jsonpickle.encode
eberrigan 1d98177
oops remove import
eberrigan 949fbe6
can attrs be unconstrained?
eberrigan 6490d1f
forgot comma
eberrigan c199061
pin attrs for testing
eberrigan 345dbc0
test Skeleton from json, template, with symmetries, and template
eberrigan 4a8c326
use SkeletonEncoder.encode
eberrigan c57e64d
black
eberrigan 4c8bdd6
try removing None values in EdgeType reduced
eberrigan 6444378
Handle case when nodes are replaced by integer indices from caller
eberrigan c232ae6
Remove prototyping notebook
talmo 2a56e88
Merge branch 'develop' into elizabeth/handle-skeleton-encoding-intern…
talmo 5319e5a
Remove attrs pins
talmo b1d757b
Remove sort keys (which flips the neccessary ordering of our py/ids)
roomrys e7fb00a
Do not add extra indents to encoded file
roomrys 743e406
Only append links after fully encoded (fat-finger)
roomrys 02865f8
Remove outdated comment
roomrys 83a2704
Lint
roomrys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the missing encoder implementation.
The
SkeletonEncoder
class is currently empty. To fulfill its purpose of replacingjson.pickle.encode
with a custom encoder, please add the necessary encoding logic within the class definition.