-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MV] Update instance state as frame idx callback #2012
[MV] Update instance state as frame idx callback #2012
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## liezl/add-gui-elements-for-sessions #2012 +/- ##
=======================================================================
- Coverage 74.18% 74.18% -0.01%
=======================================================================
Files 135 135
Lines 25441 25444 +3
=======================================================================
+ Hits 18874 18875 +1
- Misses 6567 6569 +2 ☔ View full report in Codecov by Sentry. |
ef8a496
into
liezl/add-gui-elements-for-sessions
Description
We are leaving behind the selected
"instance"
state even when we switch frame indices. The"instance"
state is meant to represent the currently selectedInstance
. This causes some unexpected behavior especially noticeable on the multiview branch where we usestate["instance"]
to determine whichInstanceGroup
(s) in the currentFrameGroup
to triangulate.Thus, this PR adds a callback to
state["frame_idx"]
to also setstate["instance"] = None
.Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️