Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: Add is [not] nullish for loose null check #1252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

auscompgeek
Copy link
Collaborator

@auscompgeek auscompgeek commented Sep 3, 2023

These check whether a LHS is nullish, i.e. null or undefined.

This is intended to complement #1255.

These check whether a LHS is nullish, i.e. null or undefined.
@AndreasArvidsson
Copy link
Collaborator

AndreasArvidsson commented Sep 17, 2023

I wonder if we just want to update these actions instead?

def code_insert_is_not_null():

The number of times you want to check just for null, but not undefined is low so I think that "is null" probably should do != null by default.

@auscompgeek
Copy link
Collaborator Author

I do agree it's pretty rare for me to check for specifically null or undefined. With #1255 it'll likely be confusing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants