Add capability to focus window by title #1262
Conversation
#Problem When an app has multiple windows focus just picks the first one it fights, which may not be the desired one, and there is not a great way to focus just the window you want. #Solution Add a new method, switcher_focus_app_title, to app_switcher.py that will focus the window whose title matches a given app name and a given regular expression. Also added a command to that will focus a window with a given spoken phrase. #Testing Verified working in current windows eleven environment.
for more information, see https://pre-commit.ci
| and window.title != "" | ||
| ): | ||
| # logging.warn(f'Checking Window: "{window.app.name}" window:"{window.title}" hidden: "{window.hidden}"') | ||
| if regex is None or re.search(regex, window.title): |
There was a problem hiding this comment.
What's your usecase for passing a regex here?
There was a problem hiding this comment.
I currently have two commands that utilize an actual regex vs a plain string.
-
Where the app title could contain one of two different things.
focus outlook: user.switcher_focus_app_title("Outlook", "(Inbox|Calendar)") -
When I don't want the title to contain a specific string.
focus studio: user.switcher_focus_app_title("Microsoft Visual Studio", "^(?:(?!Application Management).)*$")
There was a problem hiding this comment.
I think this seems reasonable given the use cases. @auscompgeek any objection or you think it's ok?
There was a problem hiding this comment.
I suppose the use-case makes sense. I'm not sure we should make this the primary way, or indeed the only way, of focusing by title, as it'd be prone to user error – it's unclear from the action name that it takes a regex.
Problem
When an app has multiple windows focus just picks the first one it fights, which may not be the desired one, and there is not a great way to focus just the window you want.
Solution
Add a new method, switcher_focus_app_title, to app_switcher.py that will focus the window whose title matches a given app name and a given regular expression. Also added a command to that will focus a window with a given spoken phrase.
Testing
Verified working in current windows eleven environment.