Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "server/workspace up/down" commands for consistency #1391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timo
Copy link
Contributor

@timo timo commented Feb 21, 2024

this mirrors "channel up/down" from the same file, and mirrors the more common "noun verb" order in commands

@fidgetingbits
Copy link
Collaborator

good idea to keep them consistent. fine by me. Should we deprecate the other two?

@timo
Copy link
Contributor Author

timo commented Mar 26, 2024

not sure if it's worth the trouble. don't know what the general stance on deprecation is in the community repo. i see the deprecate_notify function but no uses of it.

should we merge this already and create an issue for the deprecation decision of the two commands that are "backwards"?

@fidgetingbits
Copy link
Collaborator

you want to search for user.deprecate_command use instead.

I believe the stance is to always do it, see 54ce69d for a recent one.

I'm fine with merging this if you prefer to do a separate PR for deprecation. if you don't want to do it, let me know and I'll throw one together. I agree it's a bit of a hassle, but we don't have any visibility into how many people even use community afaik, and the agreement was that we slowly deprecate stuff, so still seems worth to be on the safe side.

@timo timo force-pushed the messaging_workspace_updown_commands branch from 3d8beca to 3a85f5f Compare August 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants