expand line command actions #1449

fidgetingbits · 2024-06-02T08:29:22Z

This adds two new actions for lines that allow for something like f<key> in vim (and other places) which will just jump to the first occurrence of that character.

The only debatable bit is likely the use of find as the command. Open to suggestions though.

jaresty · 2024-06-02T13:00:31Z

I dig it. I'd be interested in your feedback on this one too: #1424 (similar to vim's gm). An alternative word that could work maybe would be char (last char). Or go char and go last char.

fidgetingbits · 2024-06-02T14:13:17Z

I dig it. I'd be interested in your feedback on this one too: #1424 (similar to vim's gm). An alternative word that could work maybe would be char (last char). Or go char and go last char.

Ya, I'm a bit iffy on using find here, just happens to be what I had used in vim. I'd be fine with go char and go last char I think.

jaresty

🚢

jaresty · 2024-06-14T18:42:47Z

I wanted to share an idea that I just had about this: it would be really cool if we could add a similar command for adding a cursor at the next glyph (meaning: leave a cursor where you are now and then add another one at the next instance of this glyph)

jaresty · 2024-06-14T18:43:13Z

I wish I could merge this for you 😄

fidgetingbits · 2024-06-15T03:03:00Z

I wanted to share an idea that I just had about this: it would be really cool if we could add a similar command for adding a cursor at the next glyph (meaning: leave a cursor where you are now and then add another one at the next instance of this glyph)

can file an issue or open a separate PR for it. you'd want that to only add a cursor to the next glyph on the same line or next in the file?

makes me wonder if there should be a file for 'multiple cursor' related commands. I don't ever use them aside from with cursorless, but I suspect lots of others do. would need some common command to indicate you want to add a cursor too.

"curse" would be good but curse on/off is used for mouse cursor, so a bit confusing. but something like "curse add next char this"?

You could just do what you want in cursorless already with something like (untested) "pre char this and next view char this", but it's a bit wordy.
edit: Also I use view instead of instance.

anyway probably better to discuss in a different issue or PR if you prefer not to use cursorless for that.

jaresty · 2024-06-15T05:10:12Z

👍fwiw you can also use cursorless to navigate to the next glyph. I use multi cursor most often when I don't have access to cursorless because I'm having to work in IntelliJ.

AndreasArvidsson · 2024-06-22T15:43:40Z

We discussed this in the latest community session.

We think the action name and description should probably reflect that this is not a normal find/search command and is more like a cursor jump. Something like jump cursor to next instance of character.
We probably should have an implementation for vim. If we add an implementation of these actions to vimscript.py

fidgetingbits · 2024-07-02T13:12:27Z

We discussed this in the latest community session.

* We think the action name and description should probably reflect that this is not a normal find/search command and is more like a cursor jump. Something like jump cursor to next instance of character.

Changed the names and doc strings to reflect the feedback.

* We probably should have an implementation for vim. If we add an implementation of these actions to `vimscript.py`

vimscript.py is for the vimscript language, not for the vim app, so not applicable there. community doesn't have any native support for vim atm. Adding it is non-trivial because of mode switching, so it's not as simple as just enabling it if vim is active somewhere.

Most people using vim (afaik) used to use my personal repo, which then got broken out into talon-vim, and then partially got broken into a much simpler implementation neovim-talon, which is what will be paired with cursorless in neovim.

The neovim-talon repo will use these actions being added in this PR, so I don't think there needs to be something in community using them right away. I suspect there is probably some emacs equivalent that could be added if you think there really should be something. Or we could add something for https://marketplace.visualstudio.com/items?itemName=ArturoDent.jump-and-select, but I doubt many people are using that in vscode (could be wrong).

fidgetingbits · 2024-07-09T09:24:59Z

I did notice that zsh by default seems to bind a readline shortcut for doing this, but bash doesn't. So will need shell-specific readline overrides, which we don't support atm. I plan to add this to my branch and then port it over eventually after a bunch of testing, but not sure if it needs to be part of this PR.

I don't mind to wait though if it's preferred to have some real use cases in community.

I guess maybe of note, I have a vscode plugin scope in my branch so can enable certain commands if a vscode plugin is installed, which could be used to enable jump-and-select extension mentioned above to more cleanly add support for this into vscode as well. I haven't opened a PR to add that to community yet though.

AndreasArvidsson · 2024-07-27T16:51:00Z

Update from the community session. We think that we should probably wait with this until we actually have an implementation in community that utilizes the spoken forms.

fidgetingbits · 2024-07-28T01:27:11Z

No worries. I'll add something that uses it as part of this PR then.

for more information, see https://pre-commit.ci

fidgetingbits · 2024-08-06T09:16:46Z

Ok the scope of this is expanding now... but this implements a plugins tag and associated scope so that you can now specify if an app has a specific plugin installed. I also include action implementation for the new line command if the jump-and-select plugin is installed in vscode.

I haven't bothered moving all of the other plugin usage from vscode.talon to use this new user.plugin_installed scope, as I think it can be a follow up. But can add it here if preferred.

Also atm the test if the plugin is installed is tested on Linux only. Will test on Mac later, but if someone on Windows can hopefully chime in about where the settings file is located I'll add that too.

knausj85 · 2024-12-07T18:09:16Z

Notes from community session:
I really like this plugin idea; I'll be putting it thru some paces over the next week or so to see if we can't get this PR moving again.

knausj85

This works very well, and I think we should bring it in. Few minor details to sort through.

There were some concerns raised vis-a-vis parsing the extension file (performance?), but this approach makes sense to me.

knausj85 · 2024-12-14T23:45:43Z

apps/vscode/plugins/plugins.py

+    if not extensions.exists():
+        return []
+    with extensions.open() as f:
+        return [x["identifier"]["id"] for x in json.loads(f.read())]


Suggested change

return [x["identifier"]["id"] for x in json.loads(f.read())]

return [x["identifier"]["id"].lower() for x in json.loads(f.read())]

Just in case there are case differences, perhaps we should standardize on lower case?

knausj85 · 2024-12-14T23:46:39Z

tags/line_commands/line_commands.talon

@@ -74,3 +74,6 @@ select camel left: user.extend_camel_left()
 select camel right: user.extend_camel_right()
 go camel left: user.camel_left()
 go camel right: user.camel_right()
+
+go char <user.unmodified_key>: user.jump_cursor_to_next_char(unmodified_key)


I'm not sure these should live in line commands. Maybe they make sense alongside the plugin and be enabled with the appropriate tag? As it is, this would add some commands that won't work in a lot of applications

hrm. I do think there is the potential for this to be used elsewhere in community, though not sure of any good example where to add it off the top of my head. But for instance, I already used it in my repo for zsh line editor (would like eventually to PR that), and was going to adapt vim to use it after (though that won't become part of community) and similarly I guess people could add it for emacs (maybe there is no emacs in community). I added a separate vscode example in this PR to community specifically to justify it since we didn't want an otherwise completely dead command, but I do see your point..

Having it on the plugin side only doesn't entirely make sense due to the potential to be used inside community, but if you guys decide you don't want it in here and just want to lift the plugin stuff from this PR instead I'm good with that. Can always add it later once there is a second use case.

knausj85 · 2024-12-14T23:47:56Z

tags/plugins/plugins.py

+
+
+ui.register("win_focus", scope.update)
+ui.register("win_title", scope.update)


Do we need win_title to update the scope?

hrm, I think probably not. I don't entirely remember why I added that. This code was simplified from some vim plugin parsing I had written awhile back though, so it may have been required for vim, but I can't see why it would be for vscode. Will remove.

apps/vscode/plugins/jump-and-select.py

AndreasArvidsson · 2024-12-15T14:21:26Z

apps/vscode/plugins/plugins.py

+
+def vscode_update_plugins_list():
+    """Queries the list of vscode plugins"""
+    extensions = pathlib.Path.home() / ".vscode/extensions/extensions.json"


This line will not work for all the different clones of vscode. If you look at our application definitions we support applications like VSCodium and Cursor. Anything we add in the vscode file should ideally work on all of these.

knausj85 · 2025-01-04T17:54:00Z

tags/plugins/plugins.py

+
+@mod.scope
+def scope():
+    return {"plugin_installed": actions.user.plugins_list()}


We're thinking actions.user.plugins_list should have a VScode exclusive implementation for now. For other variants, these could be added by folks.

Long term, we're thinking to explore getting this via the command server.

I've looked into this and there isn't a simple way from the command server to know this folder path, but we can return a list of all the extensions from the command server.

phillco · 2025-01-04T18:03:32Z

tags/line_commands/line_commands.py

+    def jump_cursor_to_prev_char(char: str):
+        """Jumps the first to the previous instance of the specified character on the current line"""


qq: could you elaborate why limiting search results to the current line is valuable? I thought it was because it would wrap so you could get to stuff closer to the beginning quickly, but it looks like in vim f doesn't do that. Probably something we were missing. cc @nriley who tried it

I often fuzzily (as in I don't know the exact index so overshoot) jump to the last character on a line (and don't want to jump off the line) and also don't always want to have to speak multiple commands to go to the end of the line and then search backwards. Also helps if you are working on a single line and definitely don't want to go off that line in the event of a misrecognition/mispeak (a regularity for me).

If others don't think that's actually useful to general users happy to just close.

knausj85 · 2025-02-16T23:32:04Z

Alright, I wanna try to get this one moving again.

My take
I like both the plugin functionality and the example go char. go char's proven useful to me; so as long as no other maintainers feel super strongly, I vote we keep it as-is.

My proposal:

scope the plugin list action implementation to Microsoft VSCode proper for now. Other vscode clones can be added similarly as desired by other community members.
add a comment that the go char commands likely require a plugin to the .talon file
remove the scope update on win title if we can.
merge and move on 🙂

fidgetingbits requested review from nriley, phillco, pokey and rntz June 2, 2024 08:29

fidgetingbits mentioned this pull request Jun 2, 2024

feat: add line commands to unify with community hands-free-vim/neovim-talon#13

Merged

fidgetingbits force-pushed the better-lines branch from dce6231 to abb2ee1 Compare June 4, 2024 00:44

jaresty approved these changes Jun 4, 2024

View reviewed changes

fidgetingbits force-pushed the better-lines branch from abb2ee1 to 93c9297 Compare July 2, 2024 12:58

expand line command actions

0dc2b80

fidgetingbits force-pushed the better-lines branch from 93c9297 to 0dc2b80 Compare July 12, 2024 02:37

fidgetingbits mentioned this pull request Aug 6, 2024

update the plugin detection to use generic approach from community hands-free-vim/neovim-talon#44

Open

fidgetingbits and others added 2 commits August 6, 2024 17:12

Add plugin installed scope and a vscode char jump implementation

24524c6

[pre-commit.ci] auto fixes from pre-commit.com hooks

5beec36

for more information, see https://pre-commit.ci

knausj85 self-requested a review December 7, 2024 23:19

nriley assigned knausj85 Dec 14, 2024

nriley marked this pull request as draft December 14, 2024 17:25

Merge branch 'main' into better-lines

1ec19b7

knausj85 requested changes Dec 14, 2024

View reviewed changes

AndreasArvidsson reviewed Dec 15, 2024

View reviewed changes

knausj85 reviewed Jan 4, 2025

View reviewed changes

phillco reviewed Jan 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expand line command actions #1449

expand line command actions #1449

fidgetingbits commented Jun 2, 2024 •

edited

Loading

jaresty commented Jun 2, 2024 •

edited

Loading

fidgetingbits commented Jun 2, 2024

jaresty left a comment

jaresty commented Jun 14, 2024

jaresty commented Jun 14, 2024

fidgetingbits commented Jun 15, 2024 •

edited

Loading

jaresty commented Jun 15, 2024

AndreasArvidsson commented Jun 22, 2024

fidgetingbits commented Jul 2, 2024

fidgetingbits commented Jul 9, 2024

AndreasArvidsson commented Jul 27, 2024

fidgetingbits commented Jul 28, 2024

fidgetingbits commented Aug 6, 2024

knausj85 commented Dec 7, 2024

knausj85 left a comment

knausj85 Dec 14, 2024

knausj85 Dec 14, 2024

fidgetingbits Dec 15, 2024

knausj85 Dec 14, 2024

fidgetingbits Dec 15, 2024

AndreasArvidsson Dec 15, 2024

knausj85 Jan 4, 2025

AndreasArvidsson Jan 5, 2025 •

edited

Loading

phillco Jan 4, 2025

fidgetingbits Jan 19, 2025

knausj85 commented Feb 16, 2025 •

edited

Loading

	return [x["identifier"]["id"] for x in json.loads(f.read())]
	return [x["identifier"]["id"].lower() for x in json.loads(f.read())]



		ui.register("win_focus", scope.update)
		ui.register("win_title", scope.update)

		def jump_cursor_to_prev_char(char: str):
		"""Jumps the first to the previous instance of the specified character on the current line"""

expand line command actions #1449

Are you sure you want to change the base?

expand line command actions #1449

Conversation

fidgetingbits commented Jun 2, 2024 • edited Loading

jaresty commented Jun 2, 2024 • edited Loading

fidgetingbits commented Jun 2, 2024

jaresty left a comment

Choose a reason for hiding this comment

jaresty commented Jun 14, 2024

jaresty commented Jun 14, 2024

fidgetingbits commented Jun 15, 2024 • edited Loading

jaresty commented Jun 15, 2024

AndreasArvidsson commented Jun 22, 2024

fidgetingbits commented Jul 2, 2024

fidgetingbits commented Jul 9, 2024

AndreasArvidsson commented Jul 27, 2024

fidgetingbits commented Jul 28, 2024

fidgetingbits commented Aug 6, 2024

knausj85 commented Dec 7, 2024

knausj85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndreasArvidsson Jan 5, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knausj85 commented Feb 16, 2025 • edited Loading

fidgetingbits commented Jun 2, 2024 •

edited

Loading

jaresty commented Jun 2, 2024 •

edited

Loading

fidgetingbits commented Jun 15, 2024 •

edited

Loading

AndreasArvidsson Jan 5, 2025 •

edited

Loading

knausj85 commented Feb 16, 2025 •

edited

Loading