Improves-snap-ergonomics #1578

jaresty · 2024-10-20T03:06:56Z

This implements a few changes:

The window with focus will be the first one spoken with all layouts now
Speaking the layout alone ('snap clock' or similar) will rotate the focused windows in focus the top number in the spoken layout name
Unusable layouts cannot be spoken. There are now two lists: one for layouts that are valid in pairs, one that is a list for layouts that are valid in trios.
Added a grammar for snapping application windows or windows by stack order to specific places in a layout. You can say "snap clock app1 app2 third" to snap into a clock arrangement with windows one and two from apps 1 and 2 and the third window being the third from the top from when you spoke the command.
Added a "gap" layout item which can be used to insert spaces in a layout. Say "snap clock gap app1" to place app1 in the top right.

There are two kinds of valid layouts: - layouts that are pairs - layout that are trios While there maybe layout arrangements that are greater than twos and threes, it's difficult to say the number of applications required to trigger those layouts.

…uts.

- now if you say 'snap clock' twice in a row it will rotate the focused window

for more information, see https://pre-commit.ci

core/windows_and_tabs/window_snap.py

…nals for focus

- If you say 'snap first split' it will split without changing the order - If you say 'snap third clock' will swap the third window with the first, so you can repeat to swap them back

for more information, see https://pre-commit.ci

…e same time

- This requires a little bit more manual finesse than the previous version but it does allow you to snap specific applications and leave others alone. If you say, 'snap clock code', for example, it won't affect anything but the code windows. You can say, 'snap clock code all' to effect windows after code by appending all other windows after the code windows. If you say, 'snap clock' alone it will continue to rotate the windows as before.

for more information, see https://pre-commit.ci

- There might be a better approach, but this will at least try to snap all windows specified. (ran into an unresizable window in zoom)

- If a snap error happens, it will continue trying to snap - Struggled to maintain rotate behavior, but it seems to be working presently

…t instead of the left

- Next need to reset this variable when focus is done by other means

…o snap

- Calling focus has a delay so, we have to wait until the function is done before we can be sure that we can start listening for events again

nriley

From the community backlog session: we had a few specific comments on your implementation but are not sure the complexity of this implementation it's something we want to have in community.

core/windows_and_tabs/window_snap.py

core/windows_and_tabs/window_management.talon

jaresty · 2024-11-06T01:15:38Z

@nriley I see that you marked this as a draft - I'm not planning to change any more unless I get feedback to do so. Is it ok to mark it ready for review now?

nriley · 2024-11-06T01:26:56Z

@nriley I see that you marked this as a draft - I'm not planning to change any more unless I get feedback to do so. Is it ok to mark it ready for review now?

Sure! We just wanted to separate it out during our review session as it was still being worked on.

jaresty · 2024-11-06T02:14:30Z

Thanks! I heard from @phillco that I do still have some feedback coming so I'll wait until we meet to discuss.

- There was a concern that some people might want to rename these position names - This allows for renaming them in one location without breaking the other functionality

core/windows_and_tabs/window_snap.py

core/windows_and_tabs/window_layout.py

jaresty · 2024-11-13T19:29:11Z

core/windows_and_tabs/window_layout.py

+
+ctx = Context()
+
+ctx.lists["user.window_split_positions"] = SPLIT_POSITIONS.keys()


Move this to the top right after defining it on the module

core/windows_and_tabs/window_layout.py

jaresty · 2024-11-13T19:49:20Z

core/windows_and_tabs/window_layout.py

+    else:
+        target_length = len(filter_nonviable_windows(ui.windows()))
+    if number_small is not None:
+        return SPLIT_POSITIONS[window_split_positions][number_small]


Let's copy this here

core/windows_and_tabs/window_layout.py

- sometimes filters windows that should not be filter

- It doesn't work as effectively as just skipping when the snap fails

jaresty and others added 6 commits October 19, 2024 19:25

Make it so the focused window and snap layout is the first one spoken

9e23058

Refactor layouts to operate on windows in preparation for window layo…

85c4732

…uts.

Enable using the trio and pair snap layouts to rotate layouts

f93cf65

- now if you say 'snap clock' twice in a row it will rotate the focused window

[pre-commit.ci] auto fixes from pre-commit.com hooks

19f9202

for more information, see https://pre-commit.ci

Merge branch 'main' into improves-snap-ergonomics

8381d32

jaresty commented Oct 20, 2024

View reviewed changes

core/windows_and_tabs/window_snap.py Outdated Show resolved Hide resolved

jaresty and others added 22 commits October 19, 2024 21:26

Start counting for layouts at the active window

944f33a

Extract _top_n_windows helper function in preparation for adding ordi…

f8d1cb1

…nals for focus

Provide convenience function to pick a specific window to focus

04d1dbb

- If you say 'snap first split' it will split without changing the order - If you say 'snap third clock' will swap the third window with the first, so you can repeat to swap them back

[pre-commit.ci] auto fixes from pre-commit.com hooks

f1a94cd

for more information, see https://pre-commit.ci

Make the error message a little more intuitive

dfe59e6

Provide away to snap a window by index

f4a41da

[pre-commit.ci] auto fixes from pre-commit.com hooks

3c45207

for more information, see https://pre-commit.ci

Provide a shortcut to focus an application and snap to a layout at th…

f6c08f8

…e same time

Slightly adjust grammar based on feedback

461e109

[pre-commit.ci] auto fixes from pre-commit.com hooks

8700e87

for more information, see https://pre-commit.ci

Handle error resizing window

7dea668

- There might be a better approach, but this will at least try to snap all windows specified. (ran into an unresizable window in zoom)

Gracefully handle snap errors

f7fb7ee

- If a snap error happens, it will continue trying to snap - Struggled to maintain rotate behavior, but it seems to be working presently

Implement gap support

1509807

Refactor some duplicate code

fb70d72

Merge branch 'main' into improves-snap-ergonomics

898a8da

Cleanup extra print statements

506d0b4

Prevent an error if you tried to pop a zero number of snapped windows

77cdeff

Respond opal request feedback by making the snapping move to the righ…

96b44e7

…t instead of the left

Now it only rotates when focus was done by snap layout first

de71d32

- Next need to reset this variable when focus is done by other means

Make it so snap layout only rotates when it was the last thing used t…

d0705a1

…o snap

Optimized to fix race condition

907315e

- Calling focus has a delay so, we have to wait until the function is done before we can be sure that we can start listening for events again

nriley reviewed Oct 26, 2024

View reviewed changes

jaresty requested a review from phillco November 2, 2024 21:50

jaresty added 3 commits November 2, 2024 14:50

Merge branch 'main' into improves-snap-ergonomics

601c884

Cleanup imports

29a0c46

Merge branch 'main' into improves-snap-ergonomics

c20f601

jaresty added 3 commits November 6, 2024 12:58

Rescue another exception type that I ran into

c77aadf

Merge branch 'main' into improves-snap-ergonomics

0c09a45

Respond to pull request feedback:

096a4be

- There was a concern that some people might want to rename these position names - This allows for renaming them in one location without breaking the other functionality

phillco reviewed Nov 11, 2024

View reviewed changes

core/windows_and_tabs/window_snap.py Outdated Show resolved Hide resolved

Extract window snap positions as a talon list

23e5093