Added contacts feature, documented in core/contacts/README.md. #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfmanstout
commented
Jan 26, 2025
core/contacts/README.md
Outdated
There was a problem hiding this comment.
If preferred, I could add this section directly to the top-level readme, or link to it from there.
| @@ -120,14 +120,28 @@ def word(m) -> str: | |||
| ) | |||
|
|
|||
|
|
|||
| @mod.capture(rule="({user.vocabulary} | <phrase>)+") | |||
| @mod.capture(rule="({user.vocabulary} | <user.prose_contact> | <phrase>)+") | |||
There was a problem hiding this comment.
We could also add this to <user.word> above -- just bear in mind that it'll take multiple words to speak it, and some result in multiple words.
| ) | ||
| def raw_prose(m) -> str: | ||
| """Mixed words and punctuation, auto-spaced & capitalized, without quote straightening and commands (for use in dictation mode).""" | ||
| return apply_formatting(m) | ||
|
|
||
|
|
||
| # For dragon, omit support for abbreviations | ||
| # For dragon, omit support for abbreviations and contacts |
There was a problem hiding this comment.
Maybe it works with Dragon -- I just don't know because I don't use that anymore.
knausj85
reviewed
Feb 2, 2025
knausj85
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been holding onto this one in my fork for a while, yet it's one of the most useful extensions to community I've written. Long ago I used to put contacts into vocabulary, but they end up conflicting with other words. By adding explicit suffixes and a predictable grammar, it is so much easier to work with them. As a bonus, you never have to remember email addresses again.