Skip to content

Commit

Permalink
Update lightning_fabric.py
Browse files Browse the repository at this point in the history
  • Loading branch information
tanganke committed Dec 31, 2024
1 parent 023faec commit ddf5d58
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion fusion_bench/mixins/lightning_fabric.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import lightning as L
import torch
from lightning.fabric.connector import _is_using_cli
from lightning.fabric.loggers import TensorBoardLogger
from lightning.fabric.utilities.rank_zero import rank_zero_only
from omegaconf import DictConfig, OmegaConf
Expand Down Expand Up @@ -79,7 +80,8 @@ def setup_lightning_fabric(self, config: DictConfig):
self._fabric_instance = L.Fabric()
else:
self._fabric_instance = instantiate(config.fabric)
self._fabric_instance.launch()
if not _is_using_cli(): # if not using cli, launch the fabric
self._fabric_instance.launch()
# Set the log directory in config if it is not already set
if (
self.log_dir is not None
Expand Down

0 comments on commit ddf5d58

Please sign in to comment.