Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: refactor websocket #360

Merged
merged 11 commits into from
Nov 29, 2024
Merged

enh: refactor websocket #360

merged 11 commits into from
Nov 29, 2024

Conversation

huskar-t
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 68.81779% with 575 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (31d0a95) to head (1dd516e).

Files with missing lines Patch % Lines
controller/ws/ws/stmt.go 62.24% 202 Missing and 37 partials ⚠️
controller/ws/ws/stmt2.go 55.74% 102 Missing and 25 partials ⚠️
controller/ws/ws/fetch.go 63.93% 54 Missing and 12 partials ⚠️
controller/ws/ws/query.go 82.45% 34 Missing and 6 partials ⚠️
controller/ws/tmq/tmq.go 27.27% 29 Missing and 3 partials ⚠️
controller/ws/query/ws.go 6.06% 29 Missing and 2 partials ⚠️
tools/melody/session.go 93.33% 6 Missing and 2 partials ⚠️
controller/ws/stmt/stmt.go 50.00% 4 Missing and 2 partials ⚠️
controller/ws/ws/misc.go 76.92% 5 Missing and 1 partial ⚠️
controller/ws/ws/ws.go 76.19% 3 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              3.0     #360      +/-   ##
==========================================
+ Coverage   70.46%   72.93%   +2.47%     
==========================================
  Files          99      111      +12     
  Lines       13218    13806     +588     
==========================================
+ Hits         9314    10070     +756     
+ Misses       3159     3054     -105     
+ Partials      745      682      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huskar-t huskar-t marked this pull request as draft November 22, 2024 03:42
@huskar-t huskar-t marked this pull request as ready for review November 27, 2024 01:15
@zitsen zitsen merged commit c7dfad4 into 3.0 Nov 29, 2024
13 checks passed
@zitsen zitsen deleted the enh/xftan/TD-30186 branch November 29, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants