Merge pull request #21 from tappeddev/validate_on_new_input

fix validating after input
tappeddev · Jul 11, 2024 · a13c9eb · a13c9eb
2 parents 6a911d4 + d4d4e2c
commit a13c9eb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 25 deletions.
diff --git a/.fvm/fvm_config.json b/.fvm/fvm_config.json
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -13,13 +13,9 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
     - uses: actions/checkout@v3
-    - uses: kuhnroyal/flutter-fvm-config-action@v1
-      with:
-        path: '.fvm/fvm_config.json'
+    - uses: kuhnroyal/flutter-fvm-config-action@v2
+      id: fvm-config-action
     - uses: subosito/flutter-action@v2
-      with:
-        flutter-version: ${{ env.FLUTTER_VERSION }}
-        channel: ${{ env.FLUTTER_CHANNEL }}
     - name: Get all dependencies
       run: flutter pub get
     - name: analyze app
@@ -30,13 +26,9 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
     - uses: actions/checkout@v3
-    - uses: kuhnroyal/flutter-fvm-config-action@v1
-      with:
-        path: '.fvm/fvm_config.json'
+    - uses: kuhnroyal/flutter-fvm-config-action@v2
+      id: fvm-config-action
     - uses: subosito/flutter-action@v2
-      with:
-        flutter-version: ${{ env.FLUTTER_VERSION }}
-        channel: ${{ env.FLUTTER_CHANNEL }}
     - name: Get all dependencies
       run: flutter pub get
     - name: Check formatting
@@ -47,13 +39,9 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v3
-      - uses: kuhnroyal/flutter-fvm-config-action@v1
-        with:
-          path: '.fvm/fvm_config.json'
+      - uses: kuhnroyal/flutter-fvm-config-action@v2
+        id: fvm-config-action
       - uses: subosito/flutter-action@v2
-        with:
-          flutter-version: ${{ env.FLUTTER_VERSION }}
-          channel: ${{ env.FLUTTER_CHANNEL }}
       - name: Get all dependencies
         run: flutter pub get
       - name: Check formatting

diff --git a/lib/src/text_field/base_text_field.dart b/lib/src/text_field/base_text_field.dart
@@ -249,17 +249,22 @@ class BaseTextFieldState extends State<BaseTextField>
     _formFieldKey.currentState?.validate();
   }
 
-  void _onChanged(String value) {
+  // ignore: avoid_void_async
+  void _onChanged(String value) async {
     if (_previousTextValue == value) return;
 
     _previousTextValue = value;
 
+    widget.onChanged(value);
+
+    // we need to wait until the next microtask
+    await Future<void>.delayed(const Duration());
+
+    // ⚠️ validate after the new input is attached
     // we always want to validate the new input when the current state is invalid
     if (!_textFieldIsValid) {
       _formFieldKey.currentState?.validate();
     }
-
-    widget.onChanged(value);
   }
 
   void _addFocusNodeListener() {