Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(fix): add env pass through for cmake_osx_sysroot #50

Merged
merged 7 commits into from
May 15, 2023
Merged

build(fix): add env pass through for cmake_osx_sysroot #50

merged 7 commits into from
May 15, 2023

Conversation

leet4tari
Copy link
Contributor

Check for env RANDOMX_RS_CMAKE_OSX_SYSROOT and pass to cmake as cmake_osx_sysroot for aarch64-apple-darwin platform.

Assist with #48

SWvheerden
SWvheerden reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this

build.rs Outdated Show resolved Hide resolved
@leet4tari @SWvheerden
Update build.rs
1527324 
Co-authored-by: SW van Heerden <[email protected]>
SWvheerden
SWvheerden reviewed May 12, 2023
View reviewed changes
build.rs Outdated Show resolved Hide resolved
leet4tari and others added 2 commits May 12, 2023 14:25
SWvheerden
SWvheerden reviewed May 12, 2023
View reviewed changes
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@SWvheerden SWvheerden merged commit 7f3748b into tari-project:development May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leet4tari @SWvheerden