feat(swarm)!: allow swarm to override public urls #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)617 tests +24 616 ✅ +23 3h 55m 42s ⏱️ + 1h 42m 14s For more details on these failures, see this check. Results for commit db222ba. ± Comparison against base commit 9a0747d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(swarm): allow swarm to override public urls
Better and more descriptive names for cli and config options
Motivation and Context
Public deployments of swarm need to specify the full URL for public services. Mainly for https:// purposes.
How Has This Been Tested?
Manually, only tested that it still works as before in a non-public context
What process can a PR reviewer use to test or verify this change?
Breaking Changes
BREAKING CHANGES: config names and cli flags relating to public urls have changed