-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): setup screen mouse parallax effect #1467
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeeet very cool!
I'm going to need someone to profile this. @shanimal08 |
it should be all good, using |
@peps I'm going to leave this PR open because it's nice. The front end is currently eating a lot of memory in different places. This UX effect almost doubles memory usage during the setup screen. It does at least release the memory when we go to the main screen (where other things do not), but for now a doubling in memory isn't worth the UI benefit. If we can shrink the existing footprint I'll reconsider putting this in. |
@brianp I've made a few performance improvements.
It's strange that you're seeing double the memory usage. That shouldn't be the case. I heavily optimized the images on the setup screen so it should take up less memory than the previous build. Maybe the previous images are cached in memory? |
This adds a parallax effect to the setup section that reacts to the user's mouse. This adds a cool 3D effect and something to play around with while the setup screen is loading.
I also downsized and optimized the setup section images, so the performance impact and bundle size should be reduced.
Video demo:
https://www.loom.com/share/d40c35bb063245379a843328eeaa6a71?sid=82795738-c99e-49c7-93b4-9cbc8add0c81