-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dev dependencies in package.json #55
Conversation
1 similar comment
I think it's better to replace Would you like to make this replacement in this pr? |
@tarmolov I can look into that, yes. What do you think of dropping support for node 0.x? So we would only support node 4 and above? It means we can drop some older code and use e.g. execSync and have to worry about accessSync versus existsSync. |
I think |
But stick with a 2.x.x branch as upgrading to 3.x.x broke things.
Now that we are on node 5 or later
I've upgraded to node v5 and removed some code only necessary on older versions. I've had a go at moving to eslint, but I've decided that should be a separate PR (#59) as I'm not sure how to fix the errors it is throwing. It would be great if this could be merged, then I can rebase #57 and #58 and therefore fix #48. This would mean that my project would start validating even when it is a submodule, which will save me a lot of frustration. |
But stick with a 2.x.x version of JSCS as upgrading to 3.x.x broke things.