refactor!: remove unused util.decision.make_decision_task #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
added
the
BREAKING CHANGE
ahal
force-pushed
the
remove_make_decision_task
branch
from
4416c12 to
3621c5c
Compare
jcristau
approved these changes
Nov 30, 2023
This was added in 2eec861. It appears to have been unused then, and is unused now. I would guess this used to be used in Gecko, so made its way here, but then got dropped in Gecko at some point. This is technically backwards incompatible, so let's land with the other major changes.
ahal
force-pushed
the
remove_make_decision_task
branch
from
3621c5c to
d962b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in 2eec861. It appears to have been unused then, and is unused now. I would guess this used to be used in Gecko, so made its way here, but then got dropped in Gecko at some point.
This is technically backwards incompatible, so let's land with the other major changes.