[run-task] Support interpolating $TASK_WORKDIR in environment variables
#630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-xzlwzlwtypxp
branch
from
32c7d8b to
ad1bfef
Compare
Eijebong
reviewed
Jan 17, 2025
ahal
force-pushed
the
ahal/push-xzlwzlwtypxp
branch
from
ad1bfef to
512b52c
Compare
ahal
force-pushed
the
ahal/push-xzlwzlwtypxp
branch
from
512b52c to
3dd4b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently hard code some environment variables that should be turned into absolute paths. But it would be great if we had the ability to do this for any environment variable.
My current use case is setting
PIP_CACHE_DIRto an absolute path under the task's workdir. I could add it to the list of hard coded envs, but it would be better to do something likePIP_CACHE_DIR=$TASK_WORKDIR/.cache/pipand have run-task do the interpolation automatically.