corrected description about createNew of open in file-system.mdx #2813
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original description is exactly the opposite of the actual effect.
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
vasfvitor
requested changes
Oct 8, 2024
Comment on lines
+333
to
+337
| `createNew` works similarly to `create`, but as its name suggests, it is only takes effect when **New**: | ||
|
|
||
| That is, only allowed to be executed when the file to be opened does not exist. | ||
|
|
||
| Otherwise, the operation failed and raise an error like: `failed to open file at path: *the file path* with error: The file exists. (os error 80)`. |
There was a problem hiding this comment.
I saw your (?) comment somewhere about that it's quite the opposite way it was written before. I think we can simplify by just matching that "it fails if the file already exists" or something. No need to mention the error or explain "in other words".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR change? Give us a brief description.
The original description about
createNewofopenis exactly the opposite of the actual effect. Correct it after test.Closes #