feat: Expose window keyboard events to Tauri #12677
Draft
+604
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnfrishert
force-pushed
the
11671-expose-window-keyboard-input
branch
from
a5c3403 to
957afb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #11671, which exposes keyboard input events for Tao in Tauri on the window-level.
To safeguard against breaking changes in Tao, I've opted to use types from
keyboard-typesas the public facing API in Tauri, and written converter functions intauri-runtime-wryto move from one domain the the other.Currently the PR exposes the following attributes:
Especially the logical and physical keys were a hassle, because both enums are alike, but there are subtle differences. I hope I've done the super -> meta conversion correct, and space needed special handling as well.
I have not done any testing, because I'm not sure how to do local Tauri testing.
Draft Questions
ElementStateandKeyLocation? Right now the converter function.expects(), but I'm not sure that's the most future -proof way of handling things?