Chart Loader Optimization #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Iterating through custom songs folder only -Removed redundant customLevel null check -Add tracks to a List then return that list as enumerable -Removed serializer instance as it end up taking more memory from testing anyway Testing showed it improved loading time for ~1.2k charts from 3.5s down to 1.9s on average
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Testings
All testing were done using the DLL produced by the released build on Visual Studio Community 2023 (fully updated) and the stable version of trombone champ on steam.
Multithreading testing (average time for ~1.2k charts):
Single Thread: average 3.8s
Multi Thread (Max 2): 2.4s
Multi Thread (Max 3): 2.2s
Multi Thread (Max 4): 3.6s
Multi Thread (Max 16): 7.8s
Also asked Sailent and Sierra to test Single Thread vs Multi Thread (2 and 3). Behavior was the same with 3 threads being marginally better than 2 and 2 being a huge improvement over single threading.
Sailent Results (average time for ~500 charts)
Single Thread: average 3.6s
Multi Thread (Max 2): 1.9s
Multi Thread (Max 3): 1.7s
Sierra Results (average time for ~500 charts)
Single Thread: average 3.2s
Multi Thread (Max 2): 2.7s
Multi Thread (Max 3): 2.4s