Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: make String{,Last}IndexOf return not-found #3300

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Mar 25, 2024

Fixes #3298.

Ecma402 PR: tc39/ecma402#875

No uses in Temporal that I saw, and offhand I don't think it would be used in any other proposals.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 27, 2024
@ljharb ljharb force-pushed the string-not-found branch from 8f6480d to 5d8f62d Compare March 27, 2024 22:32
@ljharb ljharb merged commit 5d8f62d into main Mar 27, 2024
8 checks passed
@ljharb ljharb deleted the string-not-found branch March 27, 2024 22:36
ben-allen pushed a commit to tc39/ecma402 that referenced this pull request May 21, 2024
* Editorial: update for String{,Last}IndexOf returning not-found. See tc39/ecma262#3300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace -1 with a ~not-found~ sentinel in StringIndexOf and StringLastIndexOf AOs
4 participants