Editorial: Remove a paragraph for the length property of String.prototype.localeCompare #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Dec 15, 2023
spec/locale-sensitive-functions.html
Outdated
| @@ -32,7 +32,7 @@ <h1>String.prototype.localeCompare ( _that_ [ , _locales_ [ , _options_ ] ] )</h | |||
| </emu-alg> | |||
|
|
|||
| <p> | |||
| The value of the *"length"* property of the `localeCompare` method is 1. | |||
| The value of the *"length"* property of the `localeCompare` method is *1*<sub>𝔽</sub>. | |||
There was a problem hiding this comment.
Even more consistency:
Suggested change
| The value of the *"length"* property of the `localeCompare` method is *1*<sub>𝔽</sub>. | |
| The *"length"* property of the `localeCompare` method is *1*<sub>𝔽</sub>. |
But actually, it shouldn't even be necessary at all because the length of String.prototype.localeCompare ( that [ , locales [ , options ] ] ) is already 1 per ECMAScript Standard Built-in Objects:
Every built-in function object, including constructors, has a "length" property whose value is a non-negative integral Number. Unless otherwise specified, this value is the number of required parameters shown in the subclause heading for the function description. Optional parameters and rest parameters are not included in the parameter count.
Suggested change
| The value of the *"length"* property of the `localeCompare` method is *1*<sub>𝔽</sub>. |
There was a problem hiding this comment.
Thanks!
Indeed, the paragraph isn't necessary.
Updated the PR to just remove the paragraph.
…type.localeCompare
arai-a
force-pushed
the
localeCompare-length
branch
from
105e73b to
6bd493c
Compare
arai-a
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This style follows other "length" properties in this spec and the ECMAScript spec.