Editorial: Refactor Locale and Parameter Negotiation to better align with BCP 47 #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in anticipation of improving AO names.
...in anticipation of improving AO names.
…te BCP 47 "lookup"
gibson042
force-pushed
the
2024-02-locale-matching
branch
from
3f34988 to
6aac79e
Compare
ben-allen
requested changes
Mar 6, 2024
Co-authored-by: Ben Allen <[email protected]>
gibson042
force-pushed
the
2024-02-locale-matching
branch
from
8902e11 to
069c5f3
Compare
|
@ben-allen Accepted the suggestions with a few tweaks. I'm ready to land as soon as you approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit.
RFC 4647 section 2.3 defines "language priority list" as "a prioritized or weighted list of language ranges", and corresponds to requestedLocales in various ECMA-402 operations.
RFC 4647 section 3 differentiates "matching schemes" applying such lists against available locales into "filtering" (producing zero or more matches) and "lookup" (producing exactly one match). Language Tags and Locale Identifiers for the World Wide Web reinforces their significance ("Specifications that define operations on language tags or locale values using matching MUST specify whether the resulting language priority list contains a single result (lookup as defined in [RFC 4647]), or a possible empty set of results (filtering as defined in [RFC 4647])").
This PR incorporates those terms and refactors the algorithms to better align with BCP 47, consolidating many of them and establishing clear entry points at ResolveLocale for lookup and FilterLocales (née SupportedLocales) and filtering.