Make arguments optional #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, take just a single parameter for `toString` rather than an options bag. We may discover a need for additional options, but for now, canonicalization is the only one.
littledan
reviewed
Jun 11, 2024
| <p>This method generates a String representation of the current Decimal128 object, in decimal format. Unlike Number’s <emu-xref href="#sec-number.prototype.tostring">toString</emu-xref>, this method always produces a decimal representation of the Decimal128 object and never produces an exponential representation. That functionality is provided by <emu-xref href="#sec-decimal.prototype.toexponential">toExponential</emu-xref>.</p> | ||
| <p>It performs the following steps when called:</p> | ||
| <emu-alg> | ||
| 1. Let _O_ be the *this* value. | ||
| 1. Perform ? RequireInternalSlot(_O_, [[Decimal128Data]]). | ||
| 1. Let _shouldCanonicalize_ be ? Get(_options_, *"canonicalize"*). |
There was a problem hiding this comment.
Why this change? Seems unrelated.
| @@ -656,7 +655,7 @@ location: https://github.com/tc39/proposal-decimal/ | |||
| </emu-clause> | |||
|
|
|||
| <emu-clause id="sec-decimal.prototype.tofixed"> | |||
| <h1>Decimal128.prototype.toFixed ( _numDigits_ [ , _shouldCanonicalize_ ] )</h1> | |||
| <h1>Decimal128.prototype.toFixed ( [ _numDigits_ [ , _shouldCanonicalize_ ] ] )</h1> | |||
There was a problem hiding this comment.
So the change is just the .length of the function? LGTM, IMO this change can be landed even though plenary is happening now.
ptomato
approved these changes
Jun 11, 2024
|
This is handled by the work done in #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our intention for
toFixedandtoPrecisionis to allow them to take no arguments, similar to how those methods work on Numbers. I wrestled with ecmarkup to get the notation right for that, trying various things, but nothing worked. As a consequence, the best I could do was to make the first argument mandatory and the second argument optional. But there is a way! And here it is. Thanks to @ben-allen for the solution.Since this is a normative change, please do not merge this PR until after the next TC39 plenary.