Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to June feedback #158

Merged
merged 27 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2bf953f
Use a single `compare` method, working with mathematical value
jessealama Jun 12, 2024
1632169
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
f13b00c
Ensure we always return a fresh Decimal128 object
jessealama Jun 12, 2024
b3d6757
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
e716131
Restore unintentionally deleted Decimal128 object check
jessealama Jun 12, 2024
444b53a
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
ac495bc
WIP
jessealama Jun 12, 2024
148144c
Fix integer check to respect zero
jessealama Jun 12, 2024
3c2c663
Define `scale10`
jessealama Jun 12, 2024
fd5a020
Handle string canonicalization properly
jessealama Jun 12, 2024
14f65cb
Add a negation AO
jessealama Jun 12, 2024
d3c831f
Properly handle the quantum for `round`
jessealama Jun 12, 2024
7217cfc
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
880bbb4
Define mantissa and exponent methods
jessealama Jun 12, 2024
8b4c805
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
996c11b
Handle +/- zero in addition
jessealama Jun 12, 2024
f898230
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
3875cf8
Handle +/- zero in subtraction
jessealama Jun 12, 2024
59373d3
Handle +/- zero in multiplication
jessealama Jun 12, 2024
32aa2ae
Watch out for the sum/difference being equal to zero
jessealama Jun 12, 2024
fc7d5d8
Define preferred exponent
jessealama Jun 12, 2024
77d47f6
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
a9c2dc9
Add assertion
jessealama Jun 12, 2024
775c57e
Handle +/- 0 in division
jessealama Jun 12, 2024
c97b3f5
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
6e8c300
Handle +/- 0 in remainder
jessealama Jun 12, 2024
fbff409
fixup: [spec] `npm run build`
jessealama Jun 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
313 changes: 186 additions & 127 deletions index.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions intl.emu
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
</dl>
<emu-alg>
1. <ins>If _x_ is a Decimal128 value, then</ins>
1. <ins>Let _m_ be Decimal128ToDecimalString(_x_).</ins>
1. <ins>Let _m_ be Decimal128ToDecimalString(_x_, *false*).</ins>
1. <ins>Let _e_ be the truncated exponent of _x_.</ins>
1. <ins>Let _n_ be the scaled significand of _x_.</ins>
1. <ins>Else,</ins>
Expand Down Expand Up @@ -217,7 +217,7 @@
</dl>
<emu-alg>
1. <ins>If _x_ is a Decimal128 value, then</ins>
1. <ins>Let _m_ be Decimal128ToDecimalString(_x_).</ins>
1. <ins>Let _m_ be Decimal128ToDecimalString(_x_, *false*).</ins>
1. <ins>Let _f_ be the truncated exponent of _x_.</ins>
1. <ins>Let _n_ be the scaled significand of _x_.</ins>
1. Else,
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "Representing base-10 decimal numbers",
"scripts": {
"start": "npm run build-loose -- --watch",
"build": "npm run build-loose --",
"build-loose": "ecmarkup --verbose --lint-spec --strict --load-biblio @tc39/ecma262-biblio --load-biblio @tc39/ecma402-biblio spec.emu index.html"
"build": "npm run build-loose -- --strict",
"build-loose": "ecmarkup --verbose --lint-spec --load-biblio @tc39/ecma262-biblio --load-biblio @tc39/ecma402-biblio spec.emu index.html"
},
"repository": {
"type": "git",
Expand Down
Loading