Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SHA1 & SHA256 application certificate fingerprints to README #1119

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

DanyPM
Copy link

@DanyPM DanyPM commented Oct 22, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : README modification

Content

Add the app certificate fingerprint to the README file, enabling apps and users to check the integrity of apk installed from github.

Motivation and context

The main purpose is to enable subsequent verification of the app through AppVerifier, including adding the fingerprint to its internal database.

Screenshots / GIFs

Checklist

@DanyPM DanyPM changed the title Added application certificate fingerprint to README Added SHA1 & SHA256 application certificate fingerprints to README Oct 23, 2024
@yostyle
Copy link
Contributor

yostyle commented Oct 31, 2024

Thank you for your contribution. That's not the right certificate fingerprint of APKs from github. Please update it.

Github:
Signer #1 certificate SHA-256 digest: 2799b5dc1c4ee23127bffdad325db7096f5d0b4e3856f0000305e23f61f991ac
Signer #1 certificate SHA-1 digest: 48d2a6cb6a779fc8fa3b75cd56a55cc706886205

Google Play Store (your suggestion):
Signer #1 certificate SHA-256 digest: 0d9cc8cbbfac2ba6a46cccd7b2fc2714f0b71830384f4e75f36d3a7e48128d8b
Signer #1 certificate SHA-1 digest: c64612d1b02ac86e98fb7e37965b6d228e4cf6ec

@yostyle yostyle closed this Oct 31, 2024
@yostyle yostyle reopened this Oct 31, 2024
@yostyle yostyle self-requested a review October 31, 2024 15:43
@yostyle
Copy link
Contributor

yostyle commented Nov 4, 2024

@DanyPM could you update your PR ?

@DanyPM
Copy link
Author

DanyPM commented Nov 6, 2024

Thank you for the feedback. The PR has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants