Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit error when a user is not allowed to access a room. #1124

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Oct 30, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#1118

Motivation and context

Screenshots / GIFs

image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle self-assigned this Oct 30, 2024
@tchap-danger-bot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 318bb2d

Copy link

@MarcWadai MarcWadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le ticket associé est pour changer le wording afin de faire une distinction avec un message d'erreur spécifique pour les externes. Ce n'est pas le cas ici non ? On aura toujours le même message d'erreur

@yostyle
Copy link
Contributor Author

yostyle commented Oct 30, 2024

Le ticket associé est pour changer le wording afin de faire une distinction avec un message d'erreur spécifique pour les externes. Ce n'est pas le cas ici non ? On aura toujours le même message d'erreur

Actuellement l'erreur affichée est celle retournée par le serveur. Avec la modification on utilise la valeur dans l'app

Copy link

@MarcWadai MarcWadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yostyle yostyle merged commit 3153aa6 into develop Oct 30, 2024
16 of 18 checks passed
@yostyle yostyle deleted the yostyle/join_error branch October 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants