Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study impact of Spaces activation #805

Open
NicolasBuquet opened this issue Apr 11, 2023 · 2 comments
Open

Study impact of Spaces activation #805

NicolasBuquet opened this issue Apr 11, 2023 · 2 comments
Assignees
Labels

Comments

@NicolasBuquet
Copy link
Contributor

NicolasBuquet commented Apr 11, 2023

Spaces will be activated on web client. Study possible impact on mobile client.
Is it worth activating button "Change space"?

If the account is already using spaces (created via the web client or via an alternative Element mobile client), its spaces count is >= 1, an option to create Spaces is listed in bottom right button " + ":

Simulator Screen Shot - iPhone 14 - 2023-04-19 at 17 03 56

It leads to the following screen:

Simulator Screen Shot - iPhone 14 - 2023-04-19 at 17 04 48

If the account is not already using Space, Spaces are not mentioned:

Simulator Screen Shot - iPhone 14 - 2023-04-19 at 17 07 28

@NicolasBuquet
Copy link
Contributor Author

Search for comment // Tchap: Disable Spaces in iOS source code to see all disabled functionalities in Tchap linked to Spaces.

In LegacyAppDelegate properties:

  • //@Property (nonatomic, strong) SpaceDetailPresenter *spaceDetailPresenter;
  • //@Property (nonatomic, strong) SpaceFeatureUnavailablePresenter *spaceFeatureUnavailablePresenter;

In LegacyAppDelegate:application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions:

  • // self.spaceFeatureUnavailablePresenter = [SpaceFeatureUnavailablePresenter new];

In LegacyAppDelegate:handleUniversalLink:(NSUserActivity *)userActivity:

  • // if (room.summary.roomType == MXRoomTypeSpace) { … }
  • // if ([room.roomTypeString isEqualToString:MXRoomTypeStringSpace])

-> It should prevent to access a Space via an external universal link.

In LegacyAppDelegate methods:

  • (void)showSpacePreviewWithParameters:(SpacePreviewNavigationParameters*)parameters
  • (void)showSpaceWithParameters:(SpaceNavigationParameters*)parameters
  • (void)openSpaceWithId:(NSString *)spaceId
  • (void)spaceDetailPresenterDidComplete:(SpaceDetailPresenter *)presenter

-> It should prevent to preview or open a Space.

In RecentsViewController:

  • (void)showRoomDirectory
  • (void)recentListViewController:(MXKRecentListViewController *)recentListViewController didSelectSuggestedRoom:(MXSpaceChildInfo )childInfo from:(UIView _Nullable)sourceView
  • (void)spaceChildRoomDetailBridgePresenterDidCancel:(SpaceChildRoomDetailBridgePresenter *)coordinator

-> It shuold prevent to list or preview Spaces in RecentsViewController

In RoomViewController:

  • //- (void)spaceDetailPresenterDidComplete:(SpaceDetailPresenter *)presenter
  • //- (void)spaceDetailPresenter:(SpaceDetailPresenter *)presenter didOpenSpaceWithId:(NSString *)spaceId
  • //- (void)spaceDetailPresenter:(SpaceDetailPresenter *)presenter didJoinSpaceWithId:(NSString *)spaceId

-> It should prevent to join or open a Space from a link in a room.

In SideMenuCoordinator:

  • // func showCreateSpace()
  • // func showAddRoom(spaceId: String, session: MXSession)
  • // func showSpaceSettings(spaceId: String, session: MXSession)
  • // func showSpaceInvite(spaceId: String, session: MXSession)

-> It should prevent to create a Space, add a room to a Space, display Space settings or invite someone to a Space.

In SpaceCreationEmailInvitesService:

  • // func prepareIdentityService(prepared: ((String?, String?) -> Void)?, failure: ((Error?) -> Void)?)

In SpaceSettingsModalCoordinator:

  • // func exploreRooms(ofSpaceWithId spaceId: String)
  • // func showMembers(ofSpaceWithId spaceId: String)
  • // func showAccess(ofSpaceWithId spaceId: String)
  • // func exploreRoomCoordinatorDidComplete(_ coordinator: ExploreRoomCoordinatorType)
  • // func spaceMembersCoordinatorDidCancel(_ coordinator: SpaceMembersCoordinatorType)

-> It should prevent to display functionnalities about Spaces. But the SpaceSettings controller should not be called because of previously listed restrictions.

@jdauphant
Copy link

@NicolasBuquet on ne veut pas de création d'espace sur iOS pour le moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants