Skip to content

Commit

Permalink
Merge rust-bitcoin#3656: Fix typo in hash tag type
Browse files Browse the repository at this point in the history
d9ccb60 Fix typo in hash tag type (Tobin C. Harding)

Pull request description:

  In commit: `39f7dcb Reduce API surface of tagged wrapped hash types` I introduced a typo in the tagged hash tag type. Fortunately it has no effect because the tag type controls how an engine  is created (when the tag is input into the engine) and has no effect on the call to `from_engine`. However the typo makes the code confusing.

  This bug is currently unreleased.

  Fix: rust-bitcoin#3649

ACKs for top commit:
  apoelstra:
    ACK d9ccb60; successfully ran local tests

Tree-SHA512: 54cc78fb74ea119beaf4500d49a4d3954ffc3c52494b3ebc1539a3eec35078cb9388e72b42c59f371b53cced89b7b6303a0e3d3b02e59d72da182dd7bbfe2a55
  • Loading branch information
apoelstra committed Nov 26, 2024
2 parents 3aed196 + d9ccb60 commit 5958b0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bitcoin/src/taproot/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ crate::internal_macros::define_extension_trait! {
let mut eng = sha256t::Hash::<TapLeafTag>::engine();
ver.to_consensus().consensus_encode(&mut eng).expect("engines don't error");
script.consensus_encode(&mut eng).expect("engines don't error");
let inner = sha256t::Hash::<TapTweakTag>::from_engine(eng);
let inner = sha256t::Hash::<TapLeafTag>::from_engine(eng);
TapLeafHash::from_byte_array(inner.to_byte_array())
}
}
Expand Down

0 comments on commit 5958b0f

Please sign in to comment.