Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#271) domain module detekt #308

Merged
merged 15 commits into from
Mar 4, 2023
Merged

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • 도메인 모듈에 detekt를 적용하였습니다.

주요 변경 사항

  • build.yml에 domain 모듈 detekt 추가

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Mar 2, 2023
@softpeanut softpeanut self-assigned this Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #308 (cc8d83a) into main (4233073) will decrease coverage by 0.44%.
The diff coverage is 45.37%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #308      +/-   ##
============================================
- Coverage     39.02%   38.58%   -0.44%     
+ Complexity      658      654       -4     
============================================
  Files           418      420       +2     
  Lines          5128     5160      +32     
  Branches        227      226       -1     
============================================
- Hits           2001     1991      -10     
- Misses         3106     3148      +42     
  Partials         21       21              
Impacted Files Coverage Δ
...aliens/dms/domain/student/usecase/SignUpUseCase.kt 41.66% <0.00%> (-7.78%) ⬇️
...ain/studyroom/usecase/ResetAllStudyRoomsUseCase.kt 0.00% <0.00%> (ø)
...n/kotlin/team/aliens/dms/domain/file/model/File.kt 100.00% <ø> (+66.66%) ⬆️
...team/aliens/dms/domain/room/error/RoomErrorCode.kt 0.00% <0.00%> (-66.67%) ⬇️
...s/domain/studyroom/error/AvailableTimeErrorCode.kt 0.00% <0.00%> (ø)
...ns/dms/domain/studyroom/error/SeatTypeErrorCode.kt 0.00% <0.00%> (ø)
...rsistence/studyroom/StudyRoomPersistenceAdapter.kt 0.00% <0.00%> (ø)
...in/team/aliens/dms/scheduler/StudyRoomScheduler.kt 0.00% <0.00%> (ø)
...main/kotlin/team/aliens/dms/common/WebMvcConfig.kt 0.00% <0.00%> (ø)
...team/aliens/dms/domain/auth/error/AuthErrorCode.kt 84.61% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4233073...cc8d83a. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut merged commit ae4f2ce into main Mar 4, 2023
@softpeanut softpeanut deleted the feature/271-detekt-lint-domain branch March 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detekt lint 추가
4 participants