fix(DEV-13054): add create counterparts from payables and approval policies

[ayubova]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 349a505

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[costa-monite]

Nice work, thanks. The code changes are well-structured, and the introduction of the CounterpartAutocompleteWithCreate component promotes reusability.

But I have some additions that could be addressed.
Stylistic ones are conveyed as separate comments.
And more logical ones, I will write them here:

– There's considerable duplication of autocomplete logic in AutocompleteCounterparts and CounterpartAutocompleteWithCreate. May be we can do something about it now, or we can create a task for addressing it later
– ApprovalPolicyForm useEffect that sets initial form values is getting a bit long and complex, especially with the conditional logic for different trigger types. Consider breaking this down into smaller, more focused useEffect hooks, or extracting some of the logic into helper functions to improve readability

[ayubova]

@costa-monite Thanks for the feedback! I really appreciate it.

You were absolutely right about the duplication in AutocompleteCounterparts and CounterpartAutocompleteWithCreate—I’ve refactored it to make it more reusable.

As for the useEffect in ApprovalPolicyForm, I agree it could be improved, but the logic is quite complex and wasn’t written by me. I’m a bit worried about breaking something, so I’d prefer to leave it as is for now. Maybe we can create a separate task for it later.

Let me know what you think! 😊

[costa-monite]

@ayubova Thank you for the clarification and for your work! Regarding the useEffect logic, I agree that in this case, it’s best to leave it as is for now. Thanks for pointing that out

[costa-monite]

Thanks for the updates