fix(proposal): tax rate in invoice preview #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e332d54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cristinafrombr
temporarily deployed
to
common
GitHub Actions
Inactive
cristinafrombr
changed the title
cristinafrombr
temporarily deployed
to
common
GitHub Actions
Inactive
cristinafrombr
temporarily deployed
to
common
GitHub Actions
Inactive
marcperezmonite
changed the title
marcperezmonite
approved these changes
Feb 25, 2025
marcperezmonite
temporarily deployed
to
common
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue regarding lack of updates was happening with non-euro currencies.
Screen.Recording.2025-02-25.161500.mp4
Issue regarding decimal was related to how when the tax rate is typed, it returns a simple number e.g. '9' for 9%. But when it is fetched from products in backend, it's represented as '900' for 9%. I was previously not aware of the first scenario, and now code should be handling both.
