-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DEV-14246): event handlers for drop in component (multiple listeners) #623
Open
costa-monite
wants to merge
6
commits into
main
Choose a base branch
from
feat/DEV-14246-event-handlers-for-drop-in-component-multiple-listeners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(DEV-14246): event handlers for drop in component (multiple listeners) #623
costa-monite
wants to merge
6
commits into
main
from
feat/DEV-14246-event-handlers-for-drop-in-component-multiple-listeners
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1451160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0e10c49
to
5aad7c6
Compare
3 tasks
…al receivables events
e845d9e
to
ad29fa6
Compare
…mponent-multiple-listeners
🚀 Preview URLs are now available! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
How to:
Now you can listen for a specific event by passing its name to the addEventListener as the first argument
For example,
monite.event:invoice.created
will be called after successful invoice creationEvent Types and Payloads:
Benefits of this Implementation:
How to Run:
The demo is available at packages/sdk-drop-in/monite-app-demo.html
To run it:
Additional Info
There are some modifications to the sdk-react package, which aim to test other callbacks besides the invoice creation
TODO:
[ ] Remove excessive logging
[ ] Remove demo components from the app (Event log, event configuration)
[ ] Add comprehensive documentation for this integration methods
[ ] Add TypeScript types for all event types and payloads
[ ] Replace mapped listeners with actual receivables events