Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#127 개설학과 필터링 버그 해결 #129

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix/#127 개설학과 필터링 버그 해결 #129

merged 3 commits into from
Feb 1, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Feb 1, 2024 •
edited
Loading

📌 PR 요약

🌱 작업한 내용

🌱 PR 포인트

  • 새로운 강의평가 리스트를 불러오는 조건은 다음과 같습니다.
  1. 리스트의 마지막 아이템이 보일 때
  2. 개설 학과가 변경되었을 때

2가지 조건이 모두 충족된 경우 강의평가 리스트를 거의 동시에 2번 불러오게 되고 이때 Race Condition이 발생하게 됩니다.
리스트를 불러오는 함수를 임계 영역으로 설정해 문제를 해결했습니다.

📸 스크린샷

스크린샷
파일첨부바람

📮 관련 이슈

@jinukeu jinukeu added the bug Something isn't working label Feb 1, 2024
@jinukeu jinukeu self-assigned this Feb 1, 2024
@jinukeu jinukeu force-pushed the fix/#127-openmajor-lecture-filter branch from 68ac600 to 10f48eb Compare February 1, 2024 01:12
@jinukeu jinukeu force-pushed the fix/#127-openmajor-lecture-filter branch from fcb1805 to 465e418 Compare February 1, 2024 01:16
@jinukeu jinukeu merged commit 8cf04f3 into develop Feb 1, 2024
1 check passed
@jinukeu jinukeu deleted the fix/#127-openmajor-lecture-filter branch February 1, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jinukeu jinukeu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] 강의평가 개설학과 필터링
1 participant
@jinukeu