Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] util package 정리 #302

Merged
merged 4 commits into from
Jun 26, 2024
Merged

[chore] util package 정리 #302

merged 4 commits into from
Jun 26, 2024

Conversation

leeeha
Copy link
Member

@leeeha leeeha commented Jun 19, 2024

📝 Work Description

최대한 관련 있는 파일끼리 묶어서 util 패키지를 다시 정리해봤는데
패키지 분류 기준이나 네이밍 관련해서 자유롭게 의견 부탁드려요!

스크린샷 2024-06-19 오후 11 02 12

📣 To Reviewers

이번 주까지 리뷰 부탁합니다!

@leeeha leeeha added chore 🛠 버전 코드, 패키지 구조, 함수 및 변수명 변경 등의 작은 작업 하은 🐰 labels Jun 19, 2024
@leeeha leeeha requested a review from sxunea June 19, 2024 14:00
@leeeha leeeha self-assigned this Jun 19, 2024
Copy link
Contributor

@sxunea sxunea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorCode보다는 InputErrorState 와 같은 이름은 어떨까요 ? 값이 문자열이기도 하고 입력값 오류 상황을 나타내는 클래스여서요 ! 나머지는 좋습니다

leeeha added 2 commits June 26, 2024 16:16
…o feature/chore-util-package

# Conflicts:
#	app/src/main/java/org/go/sopt/winey/presentation/main/feed/WineyFeedViewModel.kt
@leeeha
Copy link
Member Author

leeeha commented Jun 26, 2024

닉네임 유효성 검증 관련해서 버그 수정하고 리팩토링 할 게 꽤 많아서 일단 머지하고 따로 PR 올릴게요!

@leeeha leeeha merged commit 2cb449d into develop Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛠 버전 코드, 패키지 구조, 함수 및 변수명 변경 등의 작은 작업 하은 🐰
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[chore] util 패키지 정리
2 participants