optimize changes

techdivision · Feb 13, 2024 · 866f0ed · 866f0ed
1 parent 0b03ff0
commit 866f0ed
Showing 1 changed file with 22 additions and 20 deletions.
diff --git a/src/Repositories/ImageTypeRepository.php b/src/Repositories/ImageTypeRepository.php
@@ -75,32 +75,34 @@ public function init()
     public function findAll()
     {
         // query whether we've already loaded the value
-        if (!isset($this->cache[__METHOD__])) {
-            // initialize the result array
-            $result = [];
-
-            // load and the image types from the EAV attribute table
-            $this->imageTypesByEntityTypeCodeAndFrontendInputStmt->execute();
+        if (isset($this->cache[__METHOD__])) {
+            return $this->cache[__METHOD__];
+        }
+        
+        // initialize the result array
+        $result = [];
 
-            // fetch the image types with the passed parameters
-            if ($imageTypes = $this->imageTypesByEntityTypeCodeAndFrontendInputStmt->fetchAll(\PDO::FETCH_ASSOC)) {
-                // iterate over the image types found
-                foreach ($imageTypes as $imageType) {
-                    $attributeCode = $imageType[MemberNames::ATTRIBUTE_CODE];
-                    // map the default image types
-                    if (isset($this->defaultMappings[$attributeCode])) {
-                        $attributeCode = $this->defaultMappings[$attributeCode];
-                    }
+        // load and the image types from the EAV attribute table
+        $this->imageTypesByEntityTypeCodeAndFrontendInputStmt->execute();
 
-                    // add the (mapped) image type
-                    $result[$attributeCode] = sprintf('%s_label', $attributeCode);
+        // fetch the image types with the passed parameters
+        if ($imageTypes = $this->imageTypesByEntityTypeCodeAndFrontendInputStmt->fetchAll(\PDO::FETCH_ASSOC)) {
+            // iterate over the image types found
+            foreach ($imageTypes as $imageType) {
+                $attributeCode = $imageType[MemberNames::ATTRIBUTE_CODE];
+                // map the default image types
+                if (isset($this->defaultMappings[$attributeCode])) {
+                    $attributeCode = $this->defaultMappings[$attributeCode];
                 }
-            }
 
-            // append to the cache
-            $this->cache[__METHOD__] = $result;
+                // add the (mapped) image type
+                $result[$attributeCode] = sprintf('%s_label', $attributeCode);
+            }
         }
 
+        // append to the cache
+        $this->cache[__METHOD__] = $result;
+
         // return from the cache
         return $this->cache[__METHOD__];
     }