Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tedious dependency to 2.7.1 #718

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

willmorgan
Copy link
Collaborator

@willmorgan willmorgan commented Oct 9, 2018

This just bumps us to a BC update containing bugfixes: tediousjs/tedious#769.

In theory this library could be upgraded to also drop Node v4 and support Tedious 3.0.

Closes #711
Fixes #470

@willmorgan
Copy link
Collaborator Author

willmorgan commented Oct 11, 2018

@patriksimek it seems AppVeyor tests randomly failed, but this is an otherwise good change to get in. Can you take a look, please?

cc: @ben-page / @bretcope / @Suraiya-Hameed

@willmorgan
Copy link
Collaborator Author

@kibertoad, @patriksimek, @ben-page, @bretcope, @Suraiya-Hameed, anyone? This is a hilariously easy upgrade and fixes issues we're facing.

This library is unusable long term unless it's actually maintained.

Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this is also another fix for pool depletion as tedious have fixed an upstream issue where connections that never established don't get rejected as errors.

@dhensby
Copy link
Collaborator

dhensby commented Oct 17, 2018

see tediousjs/tedious#769

@kibertoad
Copy link
Contributor

@willmorgan I wish I could help, but unfortunately I don't have approval permissions on this project. Can you try closing and reopening the issue to rerun tests on appveyor?
@patriksimek Would you consider merging this?

@kibertoad
Copy link
Contributor

Also we really need more maintainers on this project...

@patriksimek patriksimek merged commit 32e2285 into tediousjs:master Oct 17, 2018
@patriksimek
Copy link
Collaborator

Thank you and sorry for the delay.

@willmorgan willmorgan deleted the update-tedious-2.7.1 branch October 18, 2018 08:28
@willmorgan
Copy link
Collaborator Author

@patriksimek Thanks. @dhensby and I could perhaps take on maintainer duties to keep merging down Tedious, if that's any help?

@kibertoad Closing/reopening is a good idea for next time, thanks.

@dhensby
Copy link
Collaborator

dhensby commented Oct 18, 2018

@patriksimek thanks for releasing 4.2.2; are you using npm version to create the versions? If so, can you make sure you push the tags to the repo too?

git push origin master --follow-tags when you create a release? If you could go and run that command locally it should push up the missing tags from the GH repo (though I've manually created a 4.2.2 tag so that may conflict)

@patriksimek
Copy link
Collaborator

patriksimek commented Oct 18, 2018

@dhensby I haven't used tags at all. I was doing all the publishing manually. I know... :( I was hoping to automate that soon. If you can give me your npm username, I'll give you the publish permissions.

@willmorgan That would be pretty awesome :)

@dhensby
Copy link
Collaborator

dhensby commented Oct 18, 2018

@patriksimek dhensby

@patriksimek
Copy link
Collaborator

@dhensby Done!

@dhensby dhensby mentioned this pull request Oct 19, 2018
@dhensby
Copy link
Collaborator

dhensby commented Oct 19, 2018

I haven't used tags at all. I was doing all the publishing manually.

@patriksimek So you aren't using npm version to create the releases / bump the version numbers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tedious to fix bugs Over 2000 retries/second on connection loss
4 participants