-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tedious dependency to 2.7.1 #718
Conversation
@patriksimek it seems AppVeyor tests randomly failed, but this is an otherwise good change to get in. Can you take a look, please? cc: @ben-page / @bretcope / @Suraiya-Hameed |
@kibertoad, @patriksimek, @ben-page, @bretcope, @Suraiya-Hameed, anyone? This is a hilariously easy upgrade and fixes issues we're facing. This library is unusable long term unless it's actually maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this is also another fix for pool depletion as tedious have fixed an upstream issue where connections that never established don't get rejected as errors.
@willmorgan I wish I could help, but unfortunately I don't have approval permissions on this project. Can you try closing and reopening the issue to rerun tests on appveyor? |
Also we really need more maintainers on this project... |
Thank you and sorry for the delay. |
@patriksimek Thanks. @dhensby and I could perhaps take on maintainer duties to keep merging down Tedious, if that's any help? @kibertoad Closing/reopening is a good idea for next time, thanks. |
@patriksimek thanks for releasing 4.2.2; are you using
|
@dhensby I haven't used tags at all. I was doing all the publishing manually. I know... :( I was hoping to automate that soon. If you can give me your npm username, I'll give you the publish permissions. @willmorgan That would be pretty awesome :) |
@dhensby Done! |
@patriksimek So you aren't using |
This just bumps us to a BC update containing bugfixes: tediousjs/tedious#769.
In theory this library could be upgraded to also drop Node v4 and support Tedious 3.0.
Closes #711
Fixes #470