add money validation

tediousjs · Dec 5, 2023 · 3074459 · 3074459
1 parent 6effc24
commit 3074459
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/data-types/money.ts b/src/data-types/money.ts
@@ -49,6 +49,14 @@ const Money: DataType = {
     if (isNaN(value)) {
       throw new TypeError('Invalid number.');
     }
+    // money： -922337203685477.5808 to 922337203685477.5807
+    // in javascript -922337203685477.5808 === -922337203685477.6
+    //                922337203685477.5807 === 922337203685477.6
+    // javascript number doesn't have enough precision.
+    if (value < -922337203685477.6 || value > 922337203685477.6) {
+      throw new TypeError('Value must be between -922337203685477.5808 and 922337203685477.5807, inclusive.');
+    }
+
     return value;
   }
 };

diff --git a/test/unit/data-type.js b/test/unit/data-type.js
@@ -741,6 +741,25 @@ describe('Money', function() {
       assert.deepEqual(result, expected);
     });
   });
+
+  describe.only('.validate', function() {
+    it('throws Invalid number error for NaN input', function() {
+      assert.throws(() => {
+        TYPES.TinyInt.validate('string');
+      }, TypeError, 'Invalid number.');
+    });
+
+    it('throws Out of Range error for numbers out of range', function() {
+      assert.throws(() => {
+
+        TYPES.Money.validate(-922337203685477.5808 - 0.1);
+      }, TypeError, 'Value must be between -922337203685477.5808 and 922337203685477.5807, inclusive.');
+
+      assert.throws(() => {
+        TYPES.Money.validate(922337203685477.5807 + 0.1);
+      }, TypeError, 'Value must be between -922337203685477.5808 and 922337203685477.5807, inclusive.');
+    });
+  });
 });
 
 describe('NChar', function() {